Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use request timeout for git service rpc (#20689) #20693

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Use request timeout for git service rpc (#20689) #20693

merged 1 commit into from
Aug 7, 2022

Commits on Aug 6, 2022

  1. Use request timeout for git service rpc (go-gitea#20689) 

    This enables git.Command's Run to optionally use the given context directly so its deadline will be respected. Otherwise, it falls back to the previous behavior of using the supplied timeout or a default timeout value of 360 seconds.

repo's serviceRPC() calls now use the context's deadline (which is unset/unlimited) instead of the default 6-minute timeout. This means that large repo clones will no longer arbitrarily time out on the upload-pack step, and pushes can take longer than 6 minutes on the receive-pack step.

Fixes go-gitea#20680

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
    @parnic @lunny
    parnic and lunny committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    3370bc1 View commit details
    Browse the repository at this point in the history