Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse OAuth Authorization header when request omits client secret (#21351) #21374

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Parse OAuth Authorization header when request omits client secret (#21351) #21374

merged 2 commits into from
Oct 8, 2022

Commits on Oct 7, 2022

  1. Parse OAuth Authorization header when request omits client secret (go… 

    …-gitea#21351)

This fixes error "unauthorized_client: invalid client secret" when
client includes secret in Authorization header rather than request body.
OAuth spec permits both.

Sanity validation that client id and client secret in request are
consistent with Authorization header.

Improve error descriptions. Error codes remain the same.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
    @hickford @wxiaoguang @zeripath
    3 people committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d4b627e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Merge branch 'release/v1.17' into artanrset

    @wxiaoguang
    wxiaoguang authored Oct 8, 2022
    Configuration menu
    Copy the full SHA
    68b0f35 View commit details
    Browse the repository at this point in the history