Use ErrInvalidArgument in packages

[KN4CK3R]

Related to #22262 (comment)

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@b76970f). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #22268   +/-   ##
=======================================
  Coverage        ?   48.14%           
=======================================
  Files           ?     1043           
  Lines           ?   142380           
  Branches        ?        0           
=======================================
  Hits            ?    68550           
  Misses          ?    65645           
  Partials        ?     8185           

Impacted Files	Coverage Δ
modules/packages/composer/metadata.go	75.40% <ø> (ø)
modules/packages/helm/metadata.go	34.88% <ø> (ø)
modules/packages/npm/creator.go	84.95% <ø> (ø)
modules/packages/nuget/metadata.go	86.25% <ø> (ø)
modules/packages/nuget/symbol_extractor.go	54.54% <ø> (ø)
modules/packages/pub/metadata.go	74.02% <ø> (ø)
modules/packages/rubygems/marshal.go	47.59% <ø> (ø)
modules/packages/rubygems/metadata.go	73.25% <ø> (ø)
routers/api/packages/composer/composer.go	72.30% <0.00%> (ø)
routers/api/packages/helm/helm.go	60.24% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[zeripath]

I have a feeling we need to make a NewInvalidError function in util,

// NewInvalidError returns an error that formats as the given text but unwraps as an InvalidError
func NewInvalidError(message string) error {
  return SilentWrap{Message: message, Err: util.ErrInvalidArgument}
}

As an aside lots of the comments on the errors have gone missing in this PR.

[zeripath]

See KN4CK3R#4

[KN4CK3R]

As an aside lots of the comments on the errors have gone missing in this PR.

Not missing, I intentionaly removed them on purpose. The comments were required at the time of writing and I see no benefit in comments like

// ErrMissingComposerFile indicates a missing composer.json file
ErrMissingComposerFile = errors.New("composer.json file is missing")

[KN4CK3R]

🚀