Fix set system setting failure once it cached #22333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
outdated/backport/v1.18
delvh
reviewed
Jan 4, 2023
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Jan 7, 2023
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Jan 8, 2023
GiteaBot
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 8, 2023
Unfortunately, go-gitea#22295 introduced a bug that when set a cached system setting, it will not affect. This PR make sure to remove the cache key when updating a system setting. Fix go-gitea#22332
lunny
added a commit
that referenced
this pull request
Jan 9, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 9, 2023
* upstream/main: Replace `can not` with `cannot` (go-gitea#22372) Fix set system setting failure once it cached (go-gitea#22333) Bump json5 from 1.0.1 to 1.0.2 (go-gitea#22365) Always reuse transaction (go-gitea#22362) make /{username}.png redirect to user/org avatar (go-gitea#22356) Remove old HookEventType (go-gitea#22358)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, #22295 introduced a bug that when set a cached system setting, it will not affect.
This PR make sure to remove the cache key when updating a system setting.
Fix #22332