Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped labels #22585

Merged
merged 14 commits into from
Feb 18, 2023
Merged

Scoped labels #22585

merged 14 commits into from
Feb 18, 2023

Commits on Feb 5, 2023

  1. Label rendering refactor for consistency and code simplification

    * Labels now consistently have the same shape, emojis and tooltips everywhere.
      This includes the label list and label assignment menus.
    * In label list, show description below label same as label menus.
    * Don't use exactly black/white text colors to look a bit nicer.
    * Simplify text color computation. There is no point computing luminance in
      linear color space, as this is a perceptual problem and sRGB is closer to
      perceptually linear.
    * Increase height of label assignment menus to show more labels. Showing only
      3-4 labels at a time leads to a lot of scrolling.
    * Render all labels with a new RenderLabel template helper function.
    brechtvl committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2be8d82 View commit details
    Browse the repository at this point in the history
  2. Label creation and editing in multiline modal menu

    * Change label creation to open a modal menu like label editing.
    * Change menu layout to place name, description and colors on separate lines.
    * Don't color cancel button red in label editing modal menu.
    * Align text to the left in model menu for better readability and consistent
      with settings layout elsewhere.
    brechtvl committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2fb26a4 View commit details
    Browse the repository at this point in the history
  3. Exclusive scoped labels

    Add a new "exclusive" option per label. This makes it so that when the label is
    named `scope/name`, no other label with the same `scope/` prefix can be set on
    an issue.
    
    The scope is determined by the last occurence of `/`, so for example
    `scope/alpha/name` and `scope/beta/name` are considered to be in different
    scopes and can coexist.
    
    Exclusive scopes are not enforced by any database rules, however they are
    enforced when editing labels at the models level, automatically removing any
    existing labels in the same scope when either attaching a new label or
    replacing all labels.
    
    In menus use a circle instead of checkbox to indicate they function as radio
    buttons per scope. Issue filtering by label ensures that only a single scoped
    label is selected at a time. Clicking with alt key can be used to remove a
    scoped label, both when editing individual issues and batch editing.
    brechtvl committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    d8f108d View commit details
    Browse the repository at this point in the history
  4. Exclusive scoped labels custom rendering

    * Display scoped label prefix and suffix with slightly darker and lighter
      background color respectively, and a slanted edge between them similar to
      the `/` symbol.
    * In menus exclusive labels are grouped with a divider line.
    brechtvl committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    3513f74 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    84ff558 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1 from yardenshoham/add-blender-scoped-labels-to-…

    …migrations
    
    Add exclusive label migration
    brechtvl authored Feb 5, 2023
    Configuration menu
    Copy the full SHA
    49c68b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Fix broken reviewers menu

    brechtvl committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    6978e0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba7d8ee View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Configuration menu
    Copy the full SHA
    6706f61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc74015 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Configuration menu
    Copy the full SHA
    f3bb56e View commit details
    Browse the repository at this point in the history
  2. Grey out exclusive toggle depending if name includes scope, and show …

    …warning
    
    about what will happen with conflicting scoped labels.
    brechtvl committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    5272881 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fcf33b0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7411671 View commit details
    Browse the repository at this point in the history