Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webview: Fix overflowing diff body #22959

Merged
merged 1 commit into from
Feb 18, 2023
Merged

webview: Fix overflowing diff body #22959

merged 1 commit into from
Feb 18, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 17, 2023

If the content is quite large the diff body overflows the container and can not be read.
This is fixed by setting the diff body maximum width to 100% and enable overflow scrollbars:

before after
Screenshot_20230217_184716 Screenshot_20230217_184655

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@codecov-commenter
Copy link

Codecov Report

Merging #22959 (eaede22) into main (e7ef94e) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #22959      +/-   ##
==========================================
- Coverage   47.35%   47.34%   -0.01%     
==========================================
  Files        1121     1121              
  Lines      150300   150300              
==========================================
- Hits        71170    71165       -5     
- Misses      70686    70694       +8     
+ Partials     8444     8441       -3     
Impacted Files Coverage Δ
modules/util/timer.go 85.71% <0.00%> (-14.29%) ⬇️
modules/process/manager_exec.go 86.04% <0.00%> (-6.98%) ⬇️
modules/queue/queue_bytefifo.go 47.29% <0.00%> (-3.25%) ⬇️
modules/git/command.go 84.08% <0.00%> (-2.05%) ⬇️
services/pull/pull.go 42.72% <0.00%> (-0.80%) ⬇️
models/issues/review.go 52.17% <0.00%> (-0.57%) ⬇️
modules/queue/workerpool.go 53.33% <0.00%> (+0.47%) ⬆️
modules/git/repo_commit.go 56.41% <0.00%> (+0.89%) ⬆️
models/unit/unit.go 52.38% <0.00%> (+1.58%) ⬆️
modules/log/file.go 68.86% <0.00%> (+1.79%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2023
@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Feb 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2023
@lunny lunny merged commit 8bba7e3 into go-gitea:main Feb 18, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 20, 2023
* upstream/main:
  Fix broken pull request files (go-gitea#22962)
  Fix avatar misalignment (go-gitea#22955)
  Refactor the setting to make unit test easier (go-gitea#22405)
  Migration v244.go should be v243.go (go-gitea#22988)
  Adjust manifest to prevent tagging latest on rcs (go-gitea#22811)
  Add some guidelines for refactoring (go-gitea#22880)
  Rename `GetUnits` to `LoadUnits` (go-gitea#22970)
  Provide the ability to set password hash algorithm parameters (go-gitea#22942)
  Fix no user listed in org teams page (go-gitea#22979)
  Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (go-gitea#22950)
  Scoped labels (go-gitea#22585)
  Rename "People" to "Members" in organization page and use a better icon (go-gitea#22960)
  Rename `repo.GetOwner` to `repo.LoadOwner` (go-gitea#22967)
  Notify on container image create (go-gitea#22806)
  webview: Fix overflowing diff body (go-gitea#22959)
  Introduce customized HTML elements, fix incorrect AppUrl usages in templates (go-gitea#22861)
  Sort issues and pulls by recently updated in user and organization home (go-gitea#22925)
  Fix 404 error viewing the LFS file (go-gitea#22945)
techknowlogick pushed a commit that referenced this pull request Mar 16, 2023
This is another regression of #22959 (the first regression has been
fixed by the Image Diff fix)

Close #23517

This is a quick fix. Luckily, there is no "dropdown menu" for image/csv
view, so we could only add the "overflow-x: scroll" to the image/csv
view.

After fix:


![image](https://user-images.githubusercontent.com/2114189/225643575-9e964b4f-5543-4a69-86c2-2ffc8e40d9a6.png)


![image](https://user-images.githubusercontent.com/2114189/225643670-f0e575d0-f4af-41f4-b023-2d9ddb6462e9.png)

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Mar 17, 2023
This is another regression of go-gitea#22959 (the first regression has been
fixed by the Image Diff fix)

Close go-gitea#23517

This is a quick fix. Luckily, there is no "dropdown menu" for image/csv
view, so we could only add the "overflow-x: scroll" to the image/csv
view.

After fix:


![image](https://user-images.githubusercontent.com/2114189/225643575-9e964b4f-5543-4a69-86c2-2ffc8e40d9a6.png)


![image](https://user-images.githubusercontent.com/2114189/225643670-f0e575d0-f4af-41f4-b023-2d9ddb6462e9.png)

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants