fix submodule is nil panic #23588
Merged
fix submodule is nil panic #23588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
reviewed
Mar 20, 2023
GiteaBot
added
the
lgtm/need 2
add subomodule url is blank condition Co-authored-by: delvh <dev.lh@web.de>
silverwind
approved these changes
Mar 20, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 20, 2023
GiteaBot
added
lgtm/done
|
Does it need backport? |
lunny
added
outdated/backport/v1.19
|
ping lg-tm |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23588 +/- ##
==========================================
- Coverage 47.14% 47.13% -0.02%
==========================================
Files 1149 1154 +5
Lines 151446 152318 +872
==========================================
+ Hits 71397 71792 +395
- Misses 71611 72051 +440
- Partials 8438 8475 +37
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 20, 2023
go-gitea#23587 submodule path is nil It is panic a nil error --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
jolheiser
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 21, 2023
* upstream/main: Replace a few fontawesome icons with svg (go-gitea#23602) Fix pagination on `/notifications/watching` (go-gitea#23564) Fix `.locale.Tr` function not found in delete modal (go-gitea#23468) fix submodule is nil panic (go-gitea#23588) `Publish Review` buttons should indicate why they are disabled (go-gitea#23598) Improve template error reporting (go-gitea#23396) Polyfill the window.customElements (go-gitea#23592) Add CHANGELOG for 1.19.0 (go-gitea#23583)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23587
submodule path is nil
It is panic a nil error