Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect issue filter in user dashboard #23630
Fix incorrect issue filter in user dashboard #23630
Changes from 12 commits
5343ec1
085a44e
da6e7f8
0d7eecd
448d141
862c853
99458cb
97b4490
331a4e8
71b4011
b3e982f
1582bb1
33ba5c9
6415db9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between these functions and the ones in
repo_model
? Maybe outline in a comment the differences?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions in
repo_model
are only used here (but will cause the issue). So we can remove them or move these new functions intorepo_model
. I didn't do that because I'm not sure whether the functions inrepo_model
are only designed forissuePullAccessibleRepoCond
.The difference is that the functions in
repo_model
useissue.repo_id in repo_ids
to filter the issue, so all issues in these repos will be caught.So we need use
issue.id in issue_ids
to get the correct issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether we need to remove
repoOpts
above in this PR. it is not used.