Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport locales to 1.19 #23634

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

wxiaoguang
Copy link
Contributor

Generated by #23633

@lunny lunny added this to the 1.19.1 milestone Mar 22, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 22, 2023
@wxiaoguang wxiaoguang marked this pull request as draft March 22, 2023 12:51
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 22, 2023

Wait, find more bugs in the locale system


Update: done

@wxiaoguang wxiaoguang reopened this Mar 22, 2023
@wxiaoguang wxiaoguang marked this pull request as ready for review March 22, 2023 14:23
@@ -221,7 +211,7 @@ invalid_db_setting=Nastavení databáze je neplatné: %v
invalid_db_table=Databázová tabulka „%s“ je neplatná: %v
invalid_repo_path=Kořenový adresář repozitářů není správný: %v
invalid_app_data_path=Cesta k datům aplikace je neplatná: %v
run_user_not_match="Run as" uživatelské jméno není aktuální uživatelské jméno: %s -> %s
run_user_not_match="Run as\" uživatelské jméno není aktuální uživatelské jméno: %s -> %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be missing an end quote?

Copy link
Contributor Author

@wxiaoguang wxiaoguang Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment in #23633 (comment)

So I decided not to touch it.

And according to the behavior of current ini package usage, IIRC it doesn't need an end quote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you prefer to manually fix these quotes, I can do it: in 72ec109 , there are a lot. I can't do more at the moment because I can not sync crowdin

Many of these strings are still broken in 1.20, due to the mess of last restoring.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2023
@lunny lunny merged commit 2a70473 into go-gitea:release/v1.19 Mar 24, 2023
@wxiaoguang wxiaoguang deleted the fix-locale-backport-1.19 branch March 24, 2023 04:20
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants