Fix long project name display in issue list and in related dropdown #23653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-23625 Fixed Conflict in web_src/css/helpers.css
|
Conflicts fixed |
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Mar 23, 2023
GiteaBot
added
lgtm/need 1
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23653 +/- ##
========================================
Coverage 47.14% 47.14%
========================================
Files 1149 1155 +6
Lines 151446 152394 +948
========================================
+ Hits 71397 71849 +452
- Misses 71611 72070 +459
- Partials 8438 8475 +37
... and 43 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Mar 24, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the second problem mentioned in #23625, along with the long texts problem in
issue-item-bottom-rowofissuelist.tmplMain changes are:
max-widthto the search dropdowns in issue list and make the possible long texts inside to show ellipsis if texts are longword-break: break-word;inissue-item-bottom-rowto break the possible long texts.After the PR
issuelist in repo (similar for pr list):
dropdowns with long name (Here take reference from github to deal with the long names cases: show ellipsis with no title, because all these options are clickable, and it might not be necessary to add titles to them ):
issue page (similar for pr page):
on PC:
