Scroll collapsed file into view #23702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23702 +/- ##
==========================================
+ Coverage 47.14% 47.18% +0.03%
==========================================
Files 1149 1155 +6
Lines 151446 152396 +950
==========================================
+ Hits 71397 71901 +504
- Misses 71611 72015 +404
- Partials 8438 8480 +42
... and 47 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GiteaBot
added
the
lgtm/need 2
jpraet
added
topic/ui
|
I think this might have a dependency/interaction on #23553, so would wait until that one is in. |
# Conflicts: # web_src/css/repository.css
seems to be OK |
lunny
approved these changes
Apr 4, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Apr 4, 2023
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 4, 2023
lafriks
pushed a commit
that referenced
this pull request
Apr 5, 2023
Backport #23702 by @jpraet Fixes #23701, #23515. Alternate approach to #23604 using CSS scroll-margin-top, which is also taken into account for direct links to files in a diff: * On the PR diff, this currently shows the previous file first: https://try.gitea.io/jpraet/test/pulls/13/files#diff-b94d08b409f9d05fb65b6cccaf7b3e4ecc7cc333 * On the commit diff, the first line of the linked file is currently under the sticky header: https://try.gitea.io/jpraet/test/commit/1a19e6b14e31d295b7372f3346580c3e85690ff5#diff-b94d08b409f9d05fb65b6cccaf7b3e4ecc7cc333 Co-authored-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 5, 2023
* giteaoffical/main: Fix image border-radius (go-gitea#23886) [skip ci] Updated translations via Crowdin Scroll collapsed file into view (go-gitea#23702) docs: make the required backticks in email password more explicit (go-gitea#23923) docs: fix typo (go-gitea#23924) Update docs markdown file weight to make it clear (go-gitea#23909) Add activity feeds API (go-gitea#23494) Fix code view (diff) broken layout (go-gitea#23096) Use ghost user if package creator does not exist (go-gitea#23822) Org pages style fixes (go-gitea#23901) User/Org Feed render description as per web (go-gitea#23887)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23701, #23515.
Alternate approach to #23604 using CSS scroll-margin-top, which is also taken into account for direct links to files in a diff: