Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git dashes separator to some "log" and "diff" commands (#23606) #23720

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #23606 by @wxiaoguang

Reference: #22578 (comment)

Credits to @tdesveaux , thank you very much for catching the problem. If you'd like to open a PR, feel free to replace this one.

Git reports fatal errors for ambiguous arguments:

fatal: ambiguous argument 'refs/a...refs/b': unknown revision or path not in the working tree.
        Use '--' to separate paths from revisions, like this:
        'git <command> [<revision>...] -- [<file>...]'

So the -- separator is necessary in some cases.

…23606)

Reference:
go-gitea#22578 (comment)

Credits to @tdesveaux , thank you very much for catching the problem. If
you'd like to open a PR, feel free to replace this one.

Git reports fatal errors for ambiguous arguments:

```
fatal: ambiguous argument 'refs/a...refs/b': unknown revision or path not in the working tree.
        Use '--' to separate paths from revisions, like this:
        'git <command> [<revision>...] -- [<file>...]'
```

So the `--` separator is necessary in some cases.
@GiteaBot GiteaBot added this to the 1.19.1 milestone Mar 26, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2023
@6543 6543 enabled auto-merge (squash) April 3, 2023 22:23
@techknowlogick
Copy link
Member

🤖 🎺

@6543 6543 merged commit d752f0d into go-gitea:release/v1.19 Apr 4, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
@techknowlogick techknowlogick deleted the backport-23606-v1.19 branch September 9, 2023 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants