Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RSS icon is present on all repo tabs #23904

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 3, 2023

Previously, not all repo tabs had shown the RSS icon in the repo header because the context data was not being set. Added this context data in a new function.

Before:

image

After:

Screenshot 2023-04-04 at 00 16 17

@silverwind silverwind added this to the 1.20.0 milestone Apr 3, 2023
@6543 6543 added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Apr 3, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2023
routers/web/repo/activity.go Outdated Show resolved Hide resolved
routers/web/repo/issue.go Outdated Show resolved Hide resolved
routers/web/repo/projects.go Outdated Show resolved Hide resolved
routers/web/repo/view.go Show resolved Hide resolved
routers/web/repo/wiki.go Outdated Show resolved Hide resolved
routers/web/repo/view.go Outdated Show resolved Hide resolved
@wxiaoguang

This comment was marked as resolved.

@silverwind
Copy link
Member Author

silverwind commented Apr 4, 2023

Merged that, thanks. Yes it totally makes sense to move it into the repo context so all tabs have it. I tested it, it works as expected.

@silverwind silverwind requested a review from 6543 April 4, 2023 21:12
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 7, 2023
@lunny lunny merged commit ca5722a into go-gitea:main Apr 7, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 7, 2023
Previously, not all repo tabs had shown the RSS icon in the repo header
because the context data was not being set. Added this context data in a
new function.

Before:

<img width="806" alt="image"
src="https://user-images.githubusercontent.com/115237/229639615-9cc00e75-3a26-4ff4-a6f2-316c1fccc596.png">

After:

<img width="815" alt="Screenshot 2023-04-04 at 00 16 17"
src="https://user-images.githubusercontent.com/115237/229639201-2e1c015b-1f13-46d4-aa14-e7a82fab3982.png">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 7, 2023
6543 pushed a commit that referenced this pull request Apr 7, 2023
Backport #23904 by @silverwind

Previously, not all repo tabs had shown the RSS icon in the repo header
because the context data was not being set. Added this context data in a
new function.

Before:

<img width="806" alt="image"
src="https://user-images.githubusercontent.com/115237/229639615-9cc00e75-3a26-4ff4-a6f2-316c1fccc596.png">

After:

<img width="815" alt="Screenshot 2023-04-04 at 00 16 17"
src="https://user-images.githubusercontent.com/115237/229639201-2e1c015b-1f13-46d4-aa14-e7a82fab3982.png">

Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created outdated/backport/v1.19 This PR should be backported to Gitea 1.19 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants