Update the value of the diffEnd when click Show More btn in the DiffFileTree
#24069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
outdated/backport/v1.19
lunny
approved these changes
Apr 12, 2023
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Apr 12, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
|
Lint failing |
…guodong/gitea into bugfix/difftree_not_update_diffend
Codecov Report
@@ Coverage Diff @@
## main #24069 +/- ##
==========================================
- Coverage 47.14% 46.99% -0.15%
==========================================
Files 1149 1161 +12
Lines 151446 153729 +2283
==========================================
+ Hits 71397 72243 +846
- Misses 71611 72997 +1386
- Partials 8438 8489 +51
... and 140 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 12, 2023
…iffFileTree (go-gitea#24069) In the component `DiffFileTree`,if don't update the value of the `diffEnd` in the callback of ajax request, click `Show More` btn will always return the same response, duplicate files are appended to the file list. Before: https://user-images.githubusercontent.com/33891828/231371188-82d169af-10bb-47e2-8aca-83ced2597f2d.mov After: https://user-images.githubusercontent.com/33891828/231369805-39a5a4d0-662c-4f08-bc5a-7d31e8782453.mov --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny
pushed a commit
that referenced
this pull request
Apr 12, 2023
…iffFileTree (#24069) (#24078) Backport #24069 by @sillyguodong In the component `DiffFileTree`,if don't update the value of the `diffEnd` in the callback of ajax request, click `Show More` btn will always return the same response, duplicate files are appended to the file list. Before: https://user-images.githubusercontent.com/33891828/231371188-82d169af-10bb-47e2-8aca-83ced2597f2d.mov After: https://user-images.githubusercontent.com/33891828/231369805-39a5a4d0-662c-4f08-bc5a-7d31e8782453.mov Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 13, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Bump vm2 from 3.9.15 to 3.9.16 (go-gitea#24089) Fix difficult translation for other languages (go-gitea#24070) Fix mismatch between hook events and github event types (go-gitea#24048) Improve LFS error logs (go-gitea#24072) Update the value of the `diffEnd` when click `Show More` btn in the DiffFileTree (go-gitea#24069) Add tooltips to `Hide comment type` settings where necessary (go-gitea#21306) Use a general approach to access custom/static/builtin assets (go-gitea#24022) Make Release Download URLs predictable (go-gitea#23891) Expand selected file when clicking file tree (go-gitea#24041) Localize milestone related time strings (go-gitea#24051) update BSDmakefile to latest version from upstream (go-gitea#24063)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the component
DiffFileTree,if don't update the value of thediffEndin the callback of ajax request, clickShow Morebtn will always return the same response, duplicate files are appended to the file list.Before:
Screen.Recording.2023-04-12.at.14.18.33.mov
After:
Screen.Recording.2023-04-12.at.14.19.21.mov