fix calReleaseNumCommitsBehind #24148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repoCtx.CommitsCount is not reliably the commit count of the default branch (see Repository.GetCommitsCount)
lunny
added
the
outdated/backport/v1.19
lunny
reviewed
Apr 16, 2023
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 16, 2023
GiteaBot
added
lgtm/need 1
|
I added a I added a |
|
Sorry for the previous noise. I think this PR is now complete! (I didn't touch the code, only the tests) |
silverwind
approved these changes
Apr 17, 2023
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
I was unable to create a backport for 1.19. @oliverpool, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
oliverpool
added a commit
to oliverpool/gitea
that referenced
this pull request
Apr 18, 2023
Backport go-gitea#24148 `repoCtx.CommitsCount` is not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed). _contributed in the context of @forgejo_ --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 20, 2023
* giteaofficial/main: (26 commits) Make HTML template functions support context (go-gitea#24056) Fix issue attachment handling (go-gitea#24202) Update JS dependencies (go-gitea#24218) Remove most path-based golangci exclusions (go-gitea#24214) [skip ci] Updated translations via Crowdin Fix internal sever error when visiting a PR that bound to the deleted team (go-gitea#24127) Add owner team permission check test (go-gitea#24096) Fix incorrect CORS default values (go-gitea#24206) Add repository counter badge to repository tab (go-gitea#24205) Fix template error in pull request with deleted head repo (go-gitea#24192) Make wiki title supports dashes and improve wiki name related features (go-gitea#24143) Fix Resolve Conversation not working in Conversation view (go-gitea#24191) Vertical widths of containers removed (go-gitea#24184) Don't list root repository on compare page if pulls not allowed (go-gitea#24183) Add unset default project column (go-gitea#23531) Allow adding new files to an empty repo (go-gitea#24164) Add runner check in repo action page (go-gitea#24124) Use same action status svg icons on actions list as on action page (go-gitea#24178) [skip ci] Updated translations via Crowdin fix calReleaseNumCommitsBehind (go-gitea#24148) ... # Conflicts: # templates/repo/wiki/view.tmpl
silverwind
added a commit
that referenced
this pull request
Apr 22, 2023
Backport #24148 `repoCtx.CommitsCount` is not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed). _contributed in the context of @forgejo_ --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repoCtx.CommitsCountis not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed).For instance on the releases page the commit count is correct: https://codeberg.org/Codeberg/pages-server/releases
However it is not on the single page: https://codeberg.org/Codeberg/pages-server/releases/tag/v4.6.2
This PR fixes this by removing a "fast branch" which was using this field (I think this field should be removed, since it is a bit unpredictable - but this would mean a larger refactoring PR).
contributed in the context of @forgejo