Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hint Archived to archive label. #26741

Merged
merged 6 commits into from
Aug 27, 2023
Merged

Adding hint Archived to archive label. #26741

merged 6 commits into from
Aug 27, 2023

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Aug 26, 2023 •
edited
Loading

Followup #26478

Archived labels UI

Changed:

  • Enhanced the Filtered UI page to seamlessly incorporate a list of archived labels.

Outsourced:

  • Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request.

Screenshots
image
image
image

Part of #25237

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 26, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2023
@puni9869 puni9869 mentioned this pull request Aug 26, 2023
Closed
@puni9869
Copy link
Member Author

@silverwind / @wxiaoguang I reimagined the design for the Archived hint.
This is minimalist change.

@puni9869 puni9869 added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Aug 26, 2023
@puni9869 puni9869 added this to the 1.21.0 milestone Aug 26, 2023
@puni9869 puni9869 closed this Aug 26, 2023
@GiteaBot GiteaBot removed this from the 1.21.0 milestone Aug 26, 2023
@puni9869 puni9869 reopened this Aug 26, 2023
wxiaoguang
wxiaoguang approved these changes Aug 26, 2023
View reviewed changes
templates/repo/issue/labels/label_list.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 27, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 27, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 27, 2023
silverwind
silverwind reviewed Aug 27, 2023
View reviewed changes
web_src/css/helpers.css Outdated Show resolved Hide resolved
@silverwind silverwind enabled auto-merge (squash) August 27, 2023 09:06
@silverwind silverwind merged commit e0a796a into go-gitea:main Aug 27, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 27, 2023
@puni9869 puni9869 deleted the punit/Archive-label-hint branch August 27, 2023 12:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 28, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bc79ffa 
* giteaofficial/main:
  Fix bug for ctx usage (go-gitea#26762)
  Remove some transition related code (go-gitea#26755)
  Expanded minimum RSA Keylength to 3072 (go-gitea#26604)
  [skip ci] Updated licenses and gitignores
  Use docs.gitea.com instead of docs.gitea.io (go-gitea#26739)
  Adding hint `Archived` to archive label. (go-gitea#26741)

# Conflicts:
#	templates/base/head_navbar.tmpl
@puni9869 puni9869 mentioned this pull request Aug 30, 2023
Merged
lunny pushed a commit that referenced this pull request Sep 18, 2023
@puni9869 @silverwind
Display archived labels specially when listing labels (#26820)
a50d9af 
Follow up #26741

Changes:
Added archived label for org labels and added into issue filter list.


Part of #25237

---------

Signed-off-by: puni9869 <punitinani1@hotmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@puni9869 @lunny @silverwind @wxiaoguang @GiteaBot