Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a shortcut to user's profile page to admin user details #27299

Merged
merged 9 commits into from
Oct 8, 2023
Merged

add a shortcut to user's profile page to admin user details #27299

merged 9 commits into from
Oct 8, 2023

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Sep 27, 2023 •
edited
Loading

For admin's who need quick access to user's details page

CleanShot 2023-10-06 at 22 13 49@2x

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 27, 2023
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Sep 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 27, 2023
@silverwind
Copy link
Member

silverwind commented Sep 27, 2023 •
edited
Loading

Why red? Red should only be dangerous actions like deletion etc. Maybe a simple centered link below the user box also suffices.

denyskon
denyskon suggested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a different colour

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2023
@techknowlogick
Copy link
Member Author

updated to an icon next to username instead of a button. screenshot has been updated too

denyskon
denyskon approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit weird line indent in the code 😆 but I like the idea

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Oct 7, 2023
wxiaoguang
wxiaoguang approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent doesn't look good to me, while it doesn't bother me.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) October 8, 2023 02:19
@techknowlogick techknowlogick merged commit e96e440 into go-gitea:main Oct 8, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 8, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
8b59533 
* giteaoffical/main: (79 commits)
  Pre-register OAuth application for tea (go-gitea#27509)
  Fix mermaid flowchart margin issue (go-gitea#27503)
  add a shortcut to user's profile page to admin user details (go-gitea#27299)
  Fix actionlint (go-gitea#27513)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#27501)
  Improve feed icons and feed merge text color (go-gitea#27498)
  Downgrade `go-co-op/gocron` to v1.31.1 (go-gitea#27511)
  Enable markdownlint `no-duplicate-header` (go-gitea#27500)
  bump go-deps (go-gitea#27489)
  Apply to became a maintainer (go-gitea#27491)
  change runner for binary
  [skip ci] Updated translations via Crowdin
  Remove .exe suffix when cross-compiling on Windows (go-gitea#27448)
  move re-useable workflow
  add checkout to disk-clean
  use hosted runners for nightly actions (go-gitea#27485)
  Avoid run change title process when the title is same (go-gitea#27467)
  Fix panic in storageHandler (go-gitea#27446)
  Rename the default themes to gitea-light, gitea-dark, gitea-auto (go-gitea#27419)
  ...
@techknowlogick techknowlogick deleted the admin-shortcut branch October 8, 2023 14:01
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@techknowlogick @silverwind @wxiaoguang @denyskon @GiteaBot