Show 🚫 on the last line when a file does not end with \n

[wxiaoguang]

Follow my comment #19967 (comment)

If users want to hide the last empty line or show a block emoji (🚫) for no-newline when rendering, the new code is easier to do so in the future.

Changed the line-counting behavior to not count the last empty line on the UI. And add the "no EOL" mark to the last line.

// Gitea uses the definition (like most modern editors):
//   empty: 0 lines; "a": 1 line; "a\n": 2 lines (only 1 line is rendered); "a\nb": 2 lines;
//   When rendering, the last empty line is not rendered on UI, so "a\n" will be only rendered as one line on the UI.
//   If the content doesn't end with an EOL, there will be an icon mark at the end of last line to distinguish from the case above.

[wxiaoguang]

Show 🚫 ....

@delvh I am not a fan of putting emoji chars into the git message, especially in the "title"

[delvh]

I know, me neither.
But what's the alternative?
An unreadable title?

[silverwind]

I changed it to octicon and added tooltip. Because this is a SVG, text selection can now start over the icon as well:

[silverwind]

I think we are doing this wrong:

• Gitea shows the icon in file view, but not in diff view (after this PR)
• GitHub does not show it in file view but does show it in diff view

I find it much more important in diffs and I may actually find it annoying in file view.

[wxiaoguang]

Leave it to the future. Actually the old UI also looks good to me.

[delvh]

The PR was closed?
Not merged?
😕

[silverwind]

Because of #27391 (comment). I think it's better we only have it in diff view, not in file view.

[delvh]

I mean, at best in both for consistency, but I would have accepted it in only one as well.

[wxiaoguang]

Why I wrote this PR?

There were some discussions about the consistency of "line number" and rendered lines.

I feel that it could be improved by such approach, and I was killing my time on the train.

Why it is closed?

The old approach also looks good to me, nothing really bothers me, and I do not have time to make future improvements to satisfy every user.

[silverwind]

I mean, at best in both for consistency, but I would have accepted it in only one as well.

I think less is more. During review, a EOL change is significant enough to be highlighted, but seeing this icon in file view will get annoying soon as you may be inclined to think something is wrong with the file when it really isn't.