Improve PR diff view on mobile #27883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they are already displayed in tab menu
github hides them on small screens, too
there is currently no wrapping even on very small screens
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
sebastian-sauer
changed the title
delvh
reviewed
Nov 2, 2023
Good catch. I'll readd the information on non mobile devices. |
|
No, there I absolutely agree that we need to slim down the interface as much as possible. |
|
Updated codes and screenshots - large screens will still show the information. |
delvh
approved these changes
Nov 2, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Nov 3, 2023
pull-request-size
bot
added
size/S
wxiaoguang
approved these changes
Nov 16, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 16, 2023
* giteaofficial/main: Improve PR diff view on mobile (go-gitea#27883) Improve graceful manager code/comment (go-gitea#28063)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
1. Show diff stats only on large screens these are already shown in tabs, so no need for this duplicate information on small screens   2. Hide viewed files information on small screens Github does the same and this gives us more free space on small screens   3. Review bar now doesn't wrap so we don't need the 77px even on very small screens (the sticky headers are still working) 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are already shown in tabs, so no need for this duplicate information on small screens
Github does the same and this gives us more free space on small screens
(the sticky headers are still working)