Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Profile Readme for Organisations #27955

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Add Profile Readme for Organisations #27955

merged 10 commits into from
Nov 9, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 7, 2023 •
edited
Loading

https://blog.gitea.com/release-of-1.20.0/#-user-profile-readme-23260 (#23260) did introduce Profile Readme for Users.

This makes it usable for Organisations:

image

Sponsored by Kithara Software GmbH

@6543 6543 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Nov 7, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2023
KN4CK3R
KN4CK3R reviewed Nov 7, 2023
View reviewed changes
routers/web/org/home.go Outdated Show resolved Hide resolved
routers/web/org/home.go Outdated Show resolved Hide resolved
templates/org/home.tmpl Outdated Show resolved Hide resolved
silverwind
silverwind reviewed Nov 9, 2023
View reviewed changes
templates/org/home.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2023
@wxiaoguang
Copy link
Contributor

Is it really a good design to put the "readme" there?

If the "readme" content is short, then the "org descrption" does the same thing, is the "readme" content just redundancy?

If the "readme" content is long, then it takes a lot of space of the "org home" page, then the "search input" and the "list" position/layout is quite strange.

Indeed, the "org home page" is not the same as "user profile page".

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 9, 2023

Here is an example from Github: https://github.com/react-native-elements

@silverwind
Copy link
Member

So GitHub Readmes are in special repo .github, is that how it works for Gitea too? Both user and org.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 9, 2023 •
edited
Loading

Here is an example from Github: https://github.com/react-native-elements

Is GitHub always right? (I don't mean to block, just curious, feel free to ignore my question)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2023
@lafriks lafriks enabled auto-merge (squash) November 9, 2023 13:36
@lafriks lafriks merged commit 6035733 into go-gitea:main Nov 9, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 9, 2023
@6543 6543 deleted the profile-readme_to-orgs-too branch November 9, 2023 14:16
@yp05327 yp05327 mentioned this pull request Nov 10, 2023
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3864ed8 
* giteaofficial/main:
  Remove `title` from elements on Org mode (go-gitea#27968)
  Add Profile Readme for Organisations (go-gitea#27955)
  Allow to set explore page default sort (go-gitea#27951)
6543 pushed a commit that referenced this pull request Nov 13, 2023
@yp05327 @silverwind
Improve profile for Organizations (#27982)
089ac06 
Fixes some problems in #27955:
- autofocus of the search box
before:
if access the home page will jump to the search box

![image](https://github.com/go-gitea/gitea/assets/18380374/7f100e8d-2bd6-4563-85ba-d6008ffc71d7)
after:
will not jump to the search box

![image](https://github.com/go-gitea/gitea/assets/18380374/9aab382c-8ebe-4d18-b990-4adbb6c341ad)

- incorrect display of overview tab
before:

![image](https://github.com/go-gitea/gitea/assets/18380374/b24c79e8-9b79-4576-9276-43bd19172043)
after:

![image](https://github.com/go-gitea/gitea/assets/18380374/7aab5827-f086-4874-bd84-39bd81b872f3)

- improve the permission check to the private profile repo
In #26295, we simply added access control to the private profile.
But if user have access to the private profile repo , we should also
display the profile.

- add a button which can jump to the repo list?
I agree @wxiaoguang 's opinion here:
#27955 (comment)
But it seems that this feature is sponsored. 
So can we add a button which can quickly jump to the repo list or just
move profile to the `overview` page?

---------

Co-authored-by: silverwind <me@silverwind.io>
@jolheiser jolheiser mentioned this pull request Dec 10, 2023
Closed
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@6543 @silverwind
@KN4CK3R @fuxiaohei
Add Profile Readme for Organisations (go-gitea#27955)
b4e8a15 
https://blog.gitea.com/release-of-1.20.0/#-user-profile-readme-23260
(go-gitea#23260) did introduce Profile Readme for Users.

This makes it usable for Organisations:


![image](https://github.com/go-gitea/gitea/assets/24977596/464ab58b-a952-414b-8a34-6deaeb4f7d35)

---
*Sponsored by Kithara Software GmbH*

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@yp05327 @silverwind @fuxiaohei
Improve profile for Organizations (go-gitea#27982)
582aca8 
Fixes some problems in go-gitea#27955:
- autofocus of the search box
before:
if access the home page will jump to the search box

![image](https://github.com/go-gitea/gitea/assets/18380374/7f100e8d-2bd6-4563-85ba-d6008ffc71d7)
after:
will not jump to the search box

![image](https://github.com/go-gitea/gitea/assets/18380374/9aab382c-8ebe-4d18-b990-4adbb6c341ad)

- incorrect display of overview tab
before:

![image](https://github.com/go-gitea/gitea/assets/18380374/b24c79e8-9b79-4576-9276-43bd19172043)
after:

![image](https://github.com/go-gitea/gitea/assets/18380374/7aab5827-f086-4874-bd84-39bd81b872f3)

- improve the permission check to the private profile repo
In go-gitea#26295, we simply added access control to the private profile.
But if user have access to the private profile repo , we should also
display the profile.

- add a button which can jump to the repo list?
I agree @wxiaoguang 's opinion here:
go-gitea#27955 (comment)
But it seems that this feature is sponsored. 
So can we add a button which can quickly jump to the repo list or just
move profile to the `overview` page?

---------

Co-authored-by: silverwind <me@silverwind.io>
@6543 6543 mentioned this pull request Jan 27, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @wxiaoguang @KN4CK3R @silverwind @lafriks @GiteaBot