Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty action run title #28113

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Fix empty action run title #28113

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1747426
Fix empty action run title
lunny Nov 18, 2023
648bba0
Fix template
lunny Nov 18, 2023
b66a356
translation
lunny Nov 20, 2023
b718b89
Merge branch 'main' into lunny/empty_action_title
lunny Nov 20, 2023
1e31b1e
Follow @silverwind's suggestion
lunny Nov 21, 2023
dc67670
Merge branch 'main' into lunny/empty_action_title
lunny Nov 21, 2023
6f3060f
Follow @wxiaoguang's sugguestion
lunny Nov 21, 2023
6ed8903
Merge branch 'main' into lunny/empty_action_title
GiteaBot Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3530,6 +3530,7 @@ runs.actors_no_select = All actors
runs.status_no_select = All status
runs.no_results = No results matched.
runs.no_runs = The workflow has no runs yet.
runs.empty_commit_message = empty commit message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what I meant. Now you have actions.runs.empty_commit_message, but I wanted empty_commit_message because the next time we need this translation outside of actions context, it will be a ugly usage.


workflow.disable = Disable Workflow
workflow.disable_success = Workflow '%s' disabled successfully.
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/actions/runs_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</div>
<div class="flex-item-main">
<a class="flex-item-title" title="{{.Title}}" href="{{if .Link}}{{.Link}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
{{- .Title -}}
{{if .Title}}{{- .Title -}}{{else}}&lt;{{ctx.Locale.Tr "actions.runs.empty_commit_message"}}&gt;{{end}}
lunny marked this conversation as resolved.
Show resolved Hide resolved
lunny marked this conversation as resolved.
Show resolved Hide resolved
</a>
<div class="flex-item-body">
<b>{{if not $.CurWorkflow}}{{.WorkflowID}} {{end}}#{{.Index}}</b>:
Expand Down