Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete-orphaned-repos (#28200) #28202

Merged

Conversation

pitpalme
Copy link
Contributor

Backport #28200

gitea doctor failed at checking and fixing 'delete-orphaned-repos', because table name 'user' needs quoting to be correctly recognized by at least PostgreSQL.

fixes #28199

Backport go-gitea#28200

gitea doctor failed at checking and fixing 'delete-orphaned-repos',
because table name 'user' needs quoting to be correctly recognized by at
least PostgreSQL.

fixes go-gitea#28199
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2023
@GiteaBot GiteaBot added this to the 1.21.1 milestone Nov 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2023
@pitpalme
Copy link
Contributor Author

pitpalme commented Nov 24, 2023

I'm not sure, if it's intended to have backport PR against release branch, but I didn't find instructions on where to direct it else ...
Maybe it's me, and I didn't find the obvious location, this information is written down.
Please correct me and I'll happily edit this PR.

@lng2020
Copy link
Member

lng2020 commented Nov 24, 2023

You are doing right. Usually, the backport bot will backport for us when the backport/v1.x label is attached. But when the backport bot failed to raise a PR because of a merge conflict, we backport manually to the release branch.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2023
@techknowlogick techknowlogick merged commit 7cae4df into go-gitea:release/v1.21 Nov 24, 2023
26 checks passed
@pitpalme pitpalme deleted the backport-28200-v1.21 branch November 25, 2023 21:11
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants