Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the runs will not be displayed bug when the main branch have no workflows but other branches have #28359

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 5, 2023

The left menu will only display the default branch's workflows but the right side will display the runs triggered by all branches' workflows. So we cannot hide right side if default branch has no workflows.

Fix #28332
Replace #28333

@lunny lunny added the type/bug label Dec 5, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2023
@lunny lunny added this to the 1.22.0 milestone Dec 5, 2023
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 5, 2023
@lng2020
Copy link
Member

lng2020 commented Dec 5, 2023

#28145 is backported to 1.21. So this one should also be backported.

@lng2020 lng2020 added the backport/v1.21 This PR should be backported to Gitea 1.21 label Dec 5, 2023
@yp05327
Copy link
Contributor

yp05327 commented Dec 5, 2023

This can not completely fix the issue. But IMO, as a quick fix, this one is better.
And we can improve the left menu later:
image

ps: maybe we can also adjust the translation actions.runs.no_workflows

There are no workflows and runs yet.

@lunny
Copy link
Member Author

lunny commented Dec 5, 2023

I will leave those to other PRs but not this PR.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2023
@lunny lunny enabled auto-merge (squash) December 6, 2023 00:39
@lunny lunny merged commit 09d5028 into go-gitea:main Dec 6, 2023
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 6, 2023
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 6, 2023
techknowlogick pushed a commit that referenced this pull request Dec 6, 2023
…orkflows but other branches have (#28359) (#28365)

Backport #28359 by @lunny

The left menu will only display the default branch's workflows but the
right side will display the runs triggered by all branches' workflows.
So we cannot hide right side if default branch has no workflows.

Fix #28332 
Replace #28333

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 6, 2023
* giteaofficial/main:
  Fix the runs will not be displayed bug when the main branch have no workflows but other branches have (go-gitea#28359)
  [skip ci] Updated translations via Crowdin
  Render PyPi long description as document (go-gitea#28272)
  handle repository.size column being NULL in migration v263 (go-gitea#28336)
  Fix migration panic due to an empty review comment diff (go-gitea#28334)
  Add `HEAD` support for rpm repo files (go-gitea#28309)
  Remove deprecated query condition in ListReleases (go-gitea#28339)
@lunny lunny deleted the lunny/fix_workflows branch December 6, 2023 08:46
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Actions" tab says "There are no workflows yet."
5 participants