Adjust object format interface #28469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/api
|
One problem I see is that there will be no way to serialize ObjectFormat to database and back. This will be needed to support more than one hash format. |
We can store |
|
Correct, but deselialization function needs to be restored. |
Updated in 619483a |
AdamMajer
reviewed
Dec 14, 2023
AdamMajer
reviewed
Dec 14, 2023
wxiaoguang
reviewed
Dec 14, 2023
wxiaoguang
reviewed
Dec 14, 2023
wxiaoguang
reviewed
Dec 14, 2023
wxiaoguang
reviewed
Dec 14, 2023
wxiaoguang
reviewed
Dec 14, 2023
wxiaoguang
approved these changes
Dec 14, 2023
GiteaBot
removed
the
lgtm/need 2
GiteaBot
added
the
lgtm/need 1
wxiaoguang
reviewed
Dec 14, 2023
pull-request-size
bot
added
size/XL
wolfogre
approved these changes
Dec 15, 2023
GiteaBot
added
lgtm/done
AdamMajer
reviewed
Dec 15, 2023
lunny
force-pushed
the
lunny/adjust_object_format
branch
from
7f97ba4
to
47fedfa
Compare
pull-request-size
bot
added
size/L
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 19, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Add option to disable ambiguous unicode characters detection (go-gitea#28454) Adjust object format interface (go-gitea#28469) Remove duplicate option in admin screen and now-unused translation keys (go-gitea#28492) [skip ci] Updated translations via Crowdin Initalize stroage for orphaned repository doctor (go-gitea#28487)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
- Remove `ObjectFormatID` - Remove function `ObjectFormatFromID`. - Use `Sha1ObjectFormat` directly but not a pointer because it's an empty struct. - Store `ObjectFormatName` in `repository` struct
AdamMajer
pushed a commit
to AdamMajer/gitea
that referenced
this pull request
Jan 22, 2024
- Remove `ObjectFormatID` - Remove function `ObjectFormatFromID`. - Use `Sha1ObjectFormat` directly but not a pointer because it's an empty struct. - Store `ObjectFormatName` in `repository` struct
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
- Remove `ObjectFormatID` - Remove function `ObjectFormatFromID`. - Use `Sha1ObjectFormat` directly but not a pointer because it's an empty struct. - Store `ObjectFormatName` in `repository` struct
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectFormatIDObjectFormatFromID.Sha1ObjectFormatdirectly but not a pointer because it's an empty struct.ObjectFormatNameinrepositorystruct