Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect cookie path for AppSubURL (#29534) #29552

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Mar 3, 2024

Backport #29534 by wxiaoguang

Ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies

Regression of #24107 : at that time, I was misled by the comment Cookie path to store. Default is "/": because when AppSubURL is empty, the cookie path is not defaulted to "/". So I added a slash there. But when there is a sub path, the extra slash is wrong.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Mar 3, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 3, 2024 00:27
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2024
@wxiaoguang wxiaoguang merged commit 5ca2971 into go-gitea:release/v1.21 Mar 3, 2024
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants