Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gt-hidden to tw-hidden #30046

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Migrate gt-hidden to tw-hidden #30046

merged 4 commits into from
Mar 24, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 24, 2024

We have to define this one in helpers.css because tailwind only generates a single class but certain things rely on this being double-class. Command ran:

perl -p -i -e 's#gt-hidden#tw-hidden#g' web_src/js/**/* templates/**/* models/**/* web_src/css/**/*

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 24, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 24, 2024
Comment on lines +70 to +75
.ui.buttons .button.tw-hidden:first-child + .button {
border-left: 1px solid var(--color-light-border);
}

.ui.buttons .button:last-child,
.ui.buttons .button:nth-last-child(2):has(+ .button.gt-hidden) {
.ui.buttons .button:nth-last-child(2):has(+ .button.tw-hidden) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm… something is strange here.
How can this have any effect ever?
After all, display:none should mean that borders won't be calculated, right?
So if I'm not mistaken, we can simply delete these selector parts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike such unclear code. No test for it, not clear what it is used for.

The new code is from yesterday's #30014 ........

I ever tried to make the "buttons" clear and easy to use (#26891, with UI demos), I don't want to use too many hacky patches for buttons again.

Copy link
Member Author

@silverwind silverwind Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last-child matches on hidden elements as well, so without this selector had added the border on the invisible button and the second-to-last item that needed it had it missing. Now with this it works perfectly.

I agree the CSS on button groups is a hack and needs to be rewritten, but first we should migrate the button module from fomantic into first-party code.

Copy link
Contributor

@wxiaoguang wxiaoguang Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, why you only added nth-last-child(2), but not nth-last-child(3) even nth-last-child(4)? Many buttons could be "hidden".

For such case, maybe JS should be used to avoid such CSS tricks. Or the CSS tricks need a totally different name for special cases (and should be tested explicitly)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but first we should migrate the button module from fomantic into first-party code.

Which page/code needs such trick? I guess only one or two places at most, it's not worth to make the "buttons" that complex.

Copy link
Member Author

@silverwind silverwind Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blame view, it's the only place I remember having such a button group. Feel free to take a shot.

image image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2024
@silverwind silverwind enabled auto-merge (squash) March 24, 2024 17:41
@silverwind silverwind merged commit ec3d467 into go-gitea:main Mar 24, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 24, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 25, 2024
* origin/main:
  Remove fomantic table module (go-gitea#30047)
  Fix menu buttons in issues and release (go-gitea#30056)
  Fix git grep search limit, add test (go-gitea#30071)
  Fix button hover border (go-gitea#30048)
  Fix Add/Remove WIP on pull request title failure (go-gitea#29999)
  Fix misuse of `TxContext` (go-gitea#30061)
  Remove jQuery `.attr` from the reaction selector (go-gitea#30052)
  Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051)
  Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053)
  Remove jQuery `.attr` from the repository topic bar (go-gitea#30050)
  Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990)
  Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046)
  Forbid jQuery `is` and fix issues (go-gitea#30016)
  Remove fomantic segment module (go-gitea#30042)
  Migrate margin and padding helpers to tailwind (go-gitea#30043)
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 26, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/js modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants