v3.3/glfw: regenerate Wayland protocols #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully fix/unblock fyne-io/fyne#3131.
dmitshur
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
LGTM, thanks.
Consider changing the PR title to "v3.3/glfw: regenerate Wayland protocols". That is, to include a "v3.3/glfw:" prefix since this change only modifies the github.com/go-gl/glfw/v3.3/glfw package, and lower case letter title to better complete the sentence "This change modifies the project to ___." for consistency with https://go.dev/doc/contribute#commit_messages.
Jacalz
changed the title
|
Ah, sorry. It takes some getting used to. We don't use that naming convention over at Fyne but I promise to remember it for the next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix/unblock fyne-io/fyne#3131.