lock TagSettings structure when modified #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The map is modified in different places in the code which results in race conditions on execution. This commit locks the map with read-write lock when it is modified
|
@jinzhu why is this in v2.0 milestone? I can't see any API break here. |
mtfelian
approved these changes
Jun 29, 2018
xuyang2
pushed a commit
to easyops-cn/gorm
that referenced
this pull request
Dec 11, 2018
The map is modified in different places in the code which results in race conditions on execution. This commit locks the map with read-write lock when it is modified
blefevre
pushed a commit
to blefevre/gorm
that referenced
this pull request
Feb 17, 2020
The map is modified in different places in the code which results in race conditions on execution. This commit locks the map with read-write lock when it is modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map is modified in different places in the code which results in race conditions
on execution.
This commit locks the map with read-write lock when it is modified