Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrator run with nil schema #119

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: migrator run with nil schema #119

merged 1 commit into from
May 19, 2023

Conversation

black-06
Copy link
Contributor

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

RunWithValue stmt.Schema may be nil, then Migrator will panic.
It blocked go-gorm/gorm#6303

User Case Description

@black-06 black-06 requested a review from a631807682 May 10, 2023 02:44
@black-06 black-06 self-assigned this May 10, 2023
@jinzhu jinzhu merged commit 0bfe86f into go-gorm:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a631807682 a631807682 a631807682 approved these changes

Assignees

@black-06 black-06

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@black-06 @a631807682 @jinzhu