Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics/dogstatsd: always reset all metrics before writing them when calling WriteTo #1231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

metrics/dogstatsd: always reset all metrics before writing them when calling WriteTo #1231

wants to merge 2 commits into from

Commits on Aug 2, 2022

  1. Add test proving metrics are not properly reset on WriteTo errors

    @skwair
    skwair committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    f89002e View commit details
    Browse the repository at this point in the history

  2. fix: always reset all metrics before writing them when calling WriteTo 

    This prevents the Dogstatsd client to consume an ever-increasing amount
of memory when it fails to write somme metrics. Without this fix, if
counters can't be written, timings and histograms are not reset.
    @skwair
    skwair committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    a30f9c1 View commit details
    Browse the repository at this point in the history