Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sd): support ipv6 for consul and eureka #1274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tony612
Copy link

@tony612 tony612 commented Sep 14, 2023

Now IPv6 + port in instances will be string like 2001:db8:1::ab9:C0A8:102:8000(8000 is the port) for consul and eureka. The correct instance should be like [2001:db8:1::ab9:C0A8:102]:8000, otherwise the HTTP call will fail.

I also checked other sd. It's correct in dnssrv already:

instances[i] = net.JoinHostPort(addr.Target, fmt.Sprint(addr.Port))

Other sd seem don't have this problem either like etcd and zk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant