Canal starts sync by GTID #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Jul 31, 2017
canal/sync.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| expAlterTable = regexp.MustCompile("(?i)^ALTER\\sTABLE\\s.*?`{0,1}(.*?)`{0,1}\\.{0,1}`{0,1}([^`\\.]+?)`{0,1}\\s.*") | ||
| ) | ||
|
|
||
| func (c *Canal) startSyncBinlog() error { | ||
| pos := c.master.Position() | ||
| func getSyncer(c *Canal) (*replication.BinlogStreamer, error) { |
There was a problem hiding this comment.
getSyncer here is not proper. This function seems to start the sync.
you can name to (c *Canal) startSyncer() and then rename latter startSyncBinlog to runSyncBinlog
There was a problem hiding this comment.
@siddontang I think that rename startSyncBinlog to runSyncBinlog will cause compatibility issues.
What about delete getSyncer function and implement function logic in startSyncBinlog?
There was a problem hiding this comment.
startSyncBinlog is not exported, so it can't cause the compatibility issue.
There was a problem hiding this comment.
@siddontang fixed, plz review again
|
Thanks @NearTan |
|
Thanks @NearTan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144
masterInfowriteBinglogDumpCommand->writeBinlogDumpCommand