Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine replication/parser and test case #296

Merged
merged 3 commits into from
Jul 25, 2018
Merged

refine replication/parser and test case #296

merged 3 commits into from
Jul 25, 2018

Conversation

holys
Copy link
Contributor

@holys holys commented Jul 24, 2018

  1. use interface directly instead of pointer of interface(make it simple)
  2. refine test case to make it robust

@siddontang PTAL

siddontang
siddontang reviewed Jul 24, 2018
View reviewed changes
replication/replication_test.go
@@ -409,9 +412,14 @@ func (t *testSyncerSuite) TestMysqlBinlogCodec(c *C) {
return nil
}

err = p.ParseFile("./var/mysql.000001", 0, f)
dir, err := os.Open(binlogDir)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to close the dir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, a mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@holys
Copy link
Contributor Author

holys commented Jul 24, 2018

PTAL again @siddontang

@siddontang siddontang merged commit 535abe8 into go-mysql-org:master Jul 25, 2018
@holys holys deleted the chendahui/refine branch July 25, 2018 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holys @siddontang