Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replication delay should be updated with atomic.StoreUint32 #392

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Replication delay should be updated with atomic.StoreUint32 #392

merged 1 commit into from
Jun 15, 2019

Conversation

narkq
Copy link
Contributor

@narkq narkq commented Jun 4, 2019

For some reason delay field introduced in #380 was being updated with atomic.AddUint32, although it's a gauge metric.

@siddontang siddontang merged commit 9b07603 into go-mysql-org:master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejelith bejelith bejelith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narkq @bejelith @siddontang