Add azure basic auth verification #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
robinlieb
approved these changes
Jul 30, 2024
|
@raulcabello Thanks! |
14 tasks
weyfonk
added a commit
to weyfonk/fleet
that referenced
this pull request
Aug 7, 2024
Vendoring is no longer needed now that this PR [1] has been merged. This commit now relies on that merged logic. [1]: go-playground/webhooks#191
weyfonk
added a commit
to rancher/fleet
that referenced
this pull request
Aug 8, 2024
Vendoring is no longer needed now that this PR [1] has been merged. This commit now relies on that merged logic. [1]: go-playground/webhooks#191
p-se
pushed a commit
to p-se/fleet
that referenced
this pull request
Aug 29, 2024
Vendoring is no longer needed now that this PR [1] has been merged. This commit now relies on that merged logic. [1]: go-playground/webhooks#191
bigkevmcd
pushed a commit
to bigkevmcd/fleet
that referenced
this pull request
Sep 4, 2024
Vendoring is no longer needed now that this PR [1] has been merged. This commit now relies on that merged logic. [1]: go-playground/webhooks#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
GitHub,GitLaborBitBucketthere is no way of verifyingAzurewebhook requests.Azure allows setting basic authentication for webhooks more info. This PR uses basic authentication to perform requests validation. Basic auth can be set when creating a
Webhookwith theNewmethod just like it is done for the other git providers.It doesn't perform any validation if the username and password are not provided, which means that it doesn't introduce a breaking change.