allow setting panic func for browsers

[egonelbre]

This adds customizable panic to Browsers.

Note, I'm not sure whether adding it to RaceContext, Mouse, Keyboard and Touch is necessary. But, I can remove them and call their associated page methods.

For Pages, I needed to use the first pages .e rather than inherit it from the parents. Adding a .e to that type, would make a backwards incompatible change to Pages type and make using it more annoying. So, I decided to go the easier route and fallback to utils.E when there isn't a suitable page.

Based on #428.
Fixes #424.

[egonelbre]

Btw. is there a nice way to retrigger the github actions without having to update the PR.

I'm not sure whether this is testsuite.

[ysmood]

Btw. is there a nice way to retrigger the github actions without having to update the PR.

Do you mean this?

[egonelbre]

@ysmood I don't have sufficient permissions for it.

[egonelbre]

I ended up repushing.

[ysmood]

I ended up repushing.

I spend some time checking permission settings, seems like they don't have one for it.

[egonelbre]

Ah, also, this should be ready for review.

[ysmood]

Great! Give some time to review.

[ysmood]

Note, I'm not sure whether adding it to RaceContext, Mouse, Keyboard and Touch is necessary. But, I can remove them and call their associated page methods.

I think it's better to keep the same design as Context, for example, if a user wants to use a custom panic they can do this:

browser.WithPanic(Panic).Hijack()

The hijack can just use the e from its internal browser object.

No need to do this:

browser.Hijack().WithPanic(Panic)

[egonelbre]

@ysmood it's still taking the e from the browser.e. 965825e. There's no separate WithPanic.

Just to clarify whether I understand you correctly. It would be fine to call r.browser.e( in the methods. And the same goes for RaceContext, Mouse, Keyboard and Touch?

[ysmood]

Just to clarify whether I understand you correctly. It would be fine to call r.browser.e( in the methods. And the same goes for RaceContext, Mouse, Keyboard and Touch?

Yes, the design style is that use as few private states as possible.

[egonelbre]

Hopefully, this is more aligned with what you had in mind.

[ysmood]

Good job, almost there!

I think you forget to add the WithPanic methods for Page and Element in the must.go file?