Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull go-vela packages from server and worker #303

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

jbrockopp
Copy link
Contributor

Related to https://github.com/go-vela/community/blob/master/proposals/2021/08-25_repo-structure.md

Leftover work from go-vela/community#394 and go-vela/community#395

NOTE: Most of the added LOC in this change is in the go.sum file.

Compiler

This removes the dependency on the compiler package code from the https://github.com/go-vela/compiler repo.

The link to this package is https://github.com/go-vela/compiler/tree/master/compiler.

Instead, we'll now vendor the compiler package code from the https://github.com/go-vela/server repo.

The link to this package is https://github.com/go-vela/server/tree/master/compiler.

Executor

This removes the dependency on the executor package code from the https://github.com/go-vela/pkg-executor repo.

The link to this package is https://github.com/go-vela/pkg-executor/tree/master/executor.

Instead, we'll now vendor the executor package code from the https://github.com/go-vela/worker repo.

The link to this package is https://github.com/go-vela/worker/tree/master/executor.

Mock

This removes the dependency on the server package code from the https://github.com/go-vela/mock repo.

The link to this package is https://github.com/go-vela/mock/tree/master/server.

Instead, we'll now vendor the mock/server package code from the https://github.com/go-vela/server repo.

The link to this package is https://github.com/go-vela/server/tree/master/mock/server.

Runtime

This removes the dependency on the runtime package code from the https://github.com/go-vela/pkg-runtime repo.

The link to this package is https://github.com/go-vela/pkg-runtime/tree/master/runtime.

Instead, we'll now vendor the runtime package code from the https://github.com/go-vela/worker repo.

The link to this package is https://github.com/go-vela/worker/tree/master/runtime.

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label Nov 2, 2021
@jbrockopp jbrockopp requested a review from a team as a code owner November 2, 2021 04:15
@jbrockopp jbrockopp self-assigned this Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #303 (0aa3e90) into master (d1721df) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files         115      115           
  Lines        5139     5139           
=======================================
  Hits         4463     4463           
  Misses        554      554           
  Partials      122      122           
Impacted Files Coverage Δ
action/pipeline/exec.go 0.00% <0.00%> (ø)
command/pipeline/exec.go 0.00% <ø> (ø)
command/pipeline/validate.go 72.09% <ø> (ø)
action/pipeline/validate.go 86.88% <100.00%> (ø)

@jbrockopp jbrockopp merged commit cdf4c37 into master Nov 3, 2021
@jbrockopp jbrockopp deleted the refactor/go-vela/packages branch November 3, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants