Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exec): support yaml & yml #471

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix(exec): support yaml & yml #471

merged 1 commit into from
Aug 22, 2023

Conversation

timhuynh94
Copy link
Contributor

@timhuynh94 timhuynh94 self-assigned this Aug 21, 2023
@timhuynh94 timhuynh94 requested a review from a team as a code owner August 21, 2023 19:07
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #471 (1865d87) into main (0b58688) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   86.41%   86.35%   -0.06%     
==========================================
  Files         145      145              
  Lines        6300     6304       +4     
==========================================
  Hits         5444     5444              
- Misses        700      704       +4     
  Partials      156      156
Files Changed Coverage Δ
action/pipeline/exec.go 0.00% <0.00%> (ø)

@wass3r wass3r changed the title Yaml & yml vela exec bug fix fix(exec): support yaml & yml Aug 21, 2023
KellyMerrick
KellyMerrick approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timhuynh94 timhuynh94 merged commit dc6c700 into main Aug 22, 2023
15 of 16 checks passed
@timhuynh94 timhuynh94 deleted the issue_244 branch August 22, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@timhuynh94 timhuynh94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timhuynh94 @KellyMerrick @plyr4