Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secrets): allow schedule events for secrets #475

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix(secrets): allow schedule events for secrets #475

merged 1 commit into from
Sep 5, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Sep 5, 2023

@ecrupper ecrupper requested a review from a team as a code owner September 5, 2023 14:20
KellyMerrick
KellyMerrick approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #475 (909694c) into main (9d2d7b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   86.36%   86.37%           
=======================================
  Files         145      145           
  Lines        6308     6310    +2     
=======================================
+ Hits         5448     5450    +2     
  Misses        704      704           
  Partials      156      156
Files Changed Coverage Δ
action/secret/validate.go 100.00% <100.00%> (ø)

@ecrupper ecrupper merged commit 010e316 into main Sep 5, 2023
17 checks passed
@ecrupper ecrupper deleted the fix/secrets-schedules branch September 5, 2023 14:46
@ecrupper ecrupper mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecrupper @KellyMerrick @wass3rw3rk