Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): include starlark exec limit to compiler flags in exec + validate #504

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ecrupper
Copy link
Contributor

More parity with our actual compiler

@ecrupper ecrupper requested a review from a team as a code owner November 29, 2023 19:10
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #504 (7c73000) into main (d87ae80) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   86.00%   85.96%   -0.04%     
==========================================
  Files         145      145              
  Lines        6366     6372       +6     
==========================================
+ Hits         5475     5478       +3     
- Misses        734      737       +3     
  Partials      157      157              
Files Coverage Δ
command/pipeline/validate.go 73.58% <100.00%> (+1.58%) ⬆️
command/pipeline/exec.go 0.00% <0.00%> (ø)

@ecrupper ecrupper merged commit c20a385 into main Nov 29, 2023
14 of 16 checks passed
@ecrupper ecrupper deleted the fix/pipeline/add-starlark-exec-limit branch November 29, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants