Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): always set local to true for validate local #534

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

ecrupper
Copy link
Contributor

We've got the necessary logic packed in to the compiler code here to have ValidateLocal always use a compiler engine with local set to true.

  • If the template is of type file and the engine is local, then it will fetch from the filesystem.
  • If the template is of type github and the engine is local, it will fallthrough and attempt to fetch using user provided credentials
  • If the template is being replaced using --template-file it will source those from the filesystem like usual.

Closes go-vela/community#916

@ecrupper ecrupper requested a review from a team as a code owner February 22, 2024 14:05
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45bc445) 82.32% compared to head (693d302) 82.34%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   82.32%   82.34%   +0.02%     
==========================================
  Files         147      147              
  Lines        3620     3619       -1     
==========================================
  Hits         2980     2980              
+ Misses        473      472       -1     
  Partials      167      167              
Files Coverage Δ
command/pipeline/validate.go 65.71% <100.00%> (+1.82%) ⬆️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit db6080d into main Feb 22, 2024
16 of 17 checks passed
@ecrupper ecrupper deleted the fix/pipeline/validate-file-type branch February 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vela validate pipeline does not work with file type templates without local replace
3 participants