Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schedule): use server API types for schedule #553

Merged
merged 5 commits into from
May 9, 2024

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented Apr 29, 2024

Description

Moved Schedule out of go-vela/types and into go-vela/server. Updated imports in CLI to reflect those changes.

Related

go-vela/server#1108

@wsan3 wsan3 self-assigned this Apr 29, 2024
@wsan3 wsan3 requested a review from a team as a code owner April 29, 2024 17:58
action/schedule/table.go Show resolved Hide resolved
action/schedule/table.go Show resolved Hide resolved
action/schedule/table_test.go Show resolved Hide resolved
action/schedule/table_test.go Show resolved Hide resolved
action/schedule/table_test.go Show resolved Hide resolved
action/schedule/table_test.go Show resolved Hide resolved
action/schedule/table.go Show resolved Hide resolved
action/schedule/table.go Show resolved Hide resolved
action/schedule/add.go Show resolved Hide resolved
action/schedule/update.go Show resolved Hide resolved
@wsan3 wsan3 added the enhancement Indicates an improvement to a feature label Apr 29, 2024
@wass3rw3rk
Copy link
Member

update go.mod to pull in new types changes

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (c4a682a) to head (ec98172).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         156      156           
  Lines        3803     3803           
=======================================
  Hits         3095     3095           
  Misses        519      519           
  Partials      189      189           
Files Coverage Δ
action/schedule/add.go 90.90% <100.00%> (ø)
action/schedule/table.go 100.00% <100.00%> (ø)
action/schedule/update.go 100.00% <100.00%> (ø)

@wsan3 wsan3 merged commit f58e94d into main May 9, 2024
15 of 17 checks passed
@wsan3 wsan3 deleted the feat/show-schedule-errors branch May 9, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants