Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dashboards support #556

Merged
merged 6 commits into from
May 9, 2024
Merged

feat: dashboards support #556

merged 6 commits into from
May 9, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 7, 2024

Leverages SDK to manage dashboards. Add, update, view, and get all supported. Get will return the user's dashboards.

Was hoping to include the ability to add dashboards to a user, but the User resource is not supported in the SDK nor the CLI.

@ecrupper ecrupper requested a review from a team as a code owner May 7, 2024 16:29
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 76.50000% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (e31aae4) to head (8df08e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   81.65%   81.38%   -0.28%     
==========================================
  Files         147      156       +9     
  Lines        3603     3803     +200     
==========================================
+ Hits         2942     3095     +153     
- Misses        485      519      +34     
- Partials      176      189      +13     
Files Coverage Δ
action/dashboard/add.go 92.00% <92.00%> (ø)
action/dashboard/get.go 84.61% <84.61%> (ø)
command/dashboard/add.go 89.47% <89.47%> (ø)
command/dashboard/update.go 91.30% <91.30%> (ø)
command/dashboard/view.go 87.50% <87.50%> (ø)
command/dashboard/get.go 73.33% <73.33%> (ø)
action/dashboard/view.go 72.72% <72.72%> (ø)
action/dashboard/update.go 75.47% <75.47%> (ø)
action/dashboard/validate.go 0.00% <0.00%> (ø)

command/dashboard/view.go Outdated Show resolved Hide resolved
plyr4
plyr4 previously approved these changes May 8, 2024
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.. one question

action/dashboard/update.go Show resolved Hide resolved
@ecrupper ecrupper merged commit c4a682a into main May 9, 2024
15 of 17 checks passed
@ecrupper ecrupper deleted the feat/dashboards branch May 9, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants