Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable "go fix" once the fix for it has been merged #964

Closed
5 tasks done
wass3rw3rk opened this issue Apr 10, 2024 · 2 comments
Closed
5 tasks done

Reenable "go fix" once the fix for it has been merged #964

wass3rw3rk opened this issue Apr 10, 2024 · 2 comments
Labels
area/server Indicates a change to the server area/worker Indicates a change to the worker bug Indicates a bug good first issue Good for newcomers

Comments

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Apr 10, 2024

Description

It looks like there is an issue on Go 1.21.x+ that makes "go fix" not work if you specify x.y.z version in go.mod. the "go fix" part is temporarily commented out until the fix has been released.

Fix the validate GitHub actions once the fix has been release by Google (it looks like it's slated for 1.23).

Value

Useful Information

golang/go@7fd62ba
https://go-review.googlesource.com/c/go/+/527342
go-vela/server#1101

  1. What is the output of vela --version?
  1. What operating system is being used?
  1. Any other important details?
@wass3rw3rk wass3rw3rk added bug Indicates a bug area/server Indicates a change to the server area/worker Indicates a change to the worker labels Apr 10, 2024
@wass3r
Copy link
Collaborator

wass3r commented Aug 14, 2024

go 1.23.0 has been released, so this can be completed at any time.

@wass3rw3rk
Copy link
Member Author

all mentioned repos have been returned to their normal state for their respective github workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server Indicates a change to the server area/worker Indicates a change to the worker bug Indicates a bug good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants