Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(log): do not return log library type on add / update #242

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jun 9, 2023

Ref: go-vela/server#879

Updating the SDK to account for changes made in the above server PR.

@ecrupper ecrupper requested a review from a team as a code owner June 9, 2023 15:07
@ecrupper ecrupper self-assigned this Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #242 (0117b59) into main (2b87f24) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   91.23%   91.15%   -0.08%     
==========================================
  Files          19       19              
  Lines        1437     1425      -12     
==========================================
- Hits         1311     1299      -12     
  Misses         92       92              
  Partials       34       34              
Impacted Files Coverage Δ
vela/log.go 100.00% <100.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@ecrupper ecrupper merged commit 4dfd42c into main Jun 9, 2023
@ecrupper ecrupper deleted the enhance-no-return-log branch June 9, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants