refactor(repo)!: nested repository with migration from types #1095

ecrupper · 2024-03-26T21:53:08Z

Continuation of:

refactor(types)!: move worker type to server and nest API object #997

Context:
go-vela/community#639

codecov · 2024-03-26T21:54:28Z

Codecov Report

Attention: Patch coverage is 90.57301% with 102 lines in your changes are missing coverage. Please review.

Project coverage is 64.47%. Comparing base (b889656) to head (74aa2c9).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   61.93%   64.47%   +2.53%     
==========================================
  Files         358      370      +12     
  Lines       10901    11788     +887     
==========================================
+ Hits         6752     7600     +848     
- Misses       3663     3671       +8     
- Partials      486      517      +31

Files	Coverage Δ
api/types/actions/deploy.go	`100.00% <100.00%> (ø)`
api/types/actions/push.go	`100.00% <100.00%> (ø)`
api/types/actions/schedule.go	`100.00% <100.00%> (ø)`
api/types/events.go	`100.00% <100.00%> (ø)`
api/types/executor.go	`100.00% <100.00%> (ø)`
api/types/repo.go	`100.00% <100.00%> (ø)`
compiler/native/compile.go	`71.63% <100.00%> (ø)`
compiler/native/environment.go	`85.71% <100.00%> (ø)`
compiler/native/native.go	`87.95% <100.00%> (ø)`
database/build/count_repo.go	`100.00% <100.00%> (ø)`
... and 68 more

... and 2 files with indirect coverage changes

compiler/native/compile_test.go

database/hook/last_repo.go

database/hook/count_repo.go

api/build/update.go

ecrupper · 2024-03-26T21:55:35Z

Putting in draft right now. Functionally it's there, but I'd like to work out more comments, address some tests, and search for more optimizations

database/hook/get_repo.go

compiler/native/parse_test.go

api/types/repo.go

github-actions · 2024-04-05T16:26:44Z

api/pipeline/validate.go

@@ -69,7 +69,7 @@ import (
 // expand and validate a pipeline configuration.
 func ValidatePipeline(c *gin.Context) {


🚫 [golangci] _{reported by reviewdog 🐶}
70-109 lines are duplicate of api/pipeline/compile.go:72-111 (dupl)

scm/github/webhook.go

timhuynh94

LGTM

plyr4 · 2024-04-09T15:31:43Z

api/admin/repo.go

@@ -7,11 +7,10 @@ import (
 	"fmt"
 	"net/http"

+	"github.com/go-vela/server/api/types"


as we move everything to this pattern, any thoughts on giving every types import the api alias?

I was operating on the following pattern:

go-vela/server/api —> types

anything else —> api

But I'm open to using api always if people would prefer that

cool that works for me, not blocking either way

github-actions · 2024-04-09T17:23:24Z

database/deployment/get_repo.go

 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/database"
 	"github.com/go-vela/types/library"
 	"github.com/sirupsen/logrus"
 )

 // GetDeploymentForRepo gets a deployment by repo ID and number from the database.
-func (e *engine) GetDeploymentForRepo(ctx context.Context, r *library.Repo, number int64) (*library.Deployment, error) {
+func (e *engine) GetDeploymentForRepo(ctx context.Context, r *api.Repo, number int64) (*library.Deployment, error) {


🚫 [golangci] _{reported by reviewdog 🐶}
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

github-actions · 2024-04-09T17:23:24Z

database/deployment/count_repo.go

 	"github.com/sirupsen/logrus"
 )

 // CountDeploymentsForRepo gets the count of deployments by repo ID from the database.
-func (e *engine) CountDeploymentsForRepo(ctx context.Context, r *library.Repo) (int64, error) {
+func (e *engine) CountDeploymentsForRepo(ctx context.Context, r *api.Repo) (int64, error) {


🚫 [golangci] _{reported by reviewdog 🐶}
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

github-actions · 2024-04-09T17:23:24Z

database/deployment/list_repo.go

 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/database"
 	"github.com/go-vela/types/library"
 	"github.com/sirupsen/logrus"
 )

 // ListDeploymentsForRepo gets a list of deployments by repo ID from the database.
-func (e *engine) ListDeploymentsForRepo(ctx context.Context, r *library.Repo, page, perPage int) ([]*library.Deployment, error) {
+func (e *engine) ListDeploymentsForRepo(ctx context.Context, r *api.Repo, page, perPage int) ([]*library.Deployment, error) {


🚫 [golangci] _{reported by reviewdog 🐶}
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

database/repo/get.go

database/repo/repo.go

api/types/repo.go

wass3rw3rk

looks good overall.. a few minor things.

any thoughts around moving some of the "internal" types that live in /internal now to /internal/types/ or another location?

api/types/actions/push_test.go

api/types/string.go

api/webhook/post.go

compiler/native/parse_test.go

scm/github/changeset.go

scm/service.go

refactor: nested repository with migration from types

db2d3ea

ecrupper requested a review from a team as a code owner March 26, 2024 21:53

github-actions bot reviewed Mar 26, 2024

View reviewed changes

compiler/native/compile_test.go Outdated Show resolved Hide resolved

compiler/native/compile_test.go Outdated Show resolved Hide resolved

database/hook/last_repo.go Show resolved Hide resolved

database/hook/count_repo.go Show resolved Hide resolved

api/build/update.go Show resolved Hide resolved

ecrupper marked this pull request as draft March 26, 2024 21:55

fix integration test

f35c68a

github-actions bot reviewed Mar 27, 2024

View reviewed changes

database/hook/get_repo.go Show resolved Hide resolved

condense item

f1dd103

github-actions bot reviewed Mar 27, 2024

View reviewed changes

compiler/native/parse_test.go Outdated Show resolved Hide resolved

ecrupper added 2 commits March 27, 2024 14:08

move item to models pkg in queue

c4d8898

Merge branch 'main' into refactor/nested-api/repository

6644dbd

ecrupper marked this pull request as ready for review April 2, 2024 15:55

github-actions bot reviewed Apr 2, 2024

View reviewed changes

api/types/repo.go Outdated Show resolved Hide resolved

ecrupper added 2 commits April 3, 2024 11:57

fix some linter errors and bring in string_test file

2086af7

Merge branch 'main' into refactor/nested-api/repository

903a962

github-actions bot reviewed Apr 5, 2024

View reviewed changes

Merge branch 'main' into refactor/nested-api/repository

189d0f0

github-actions bot reviewed Apr 8, 2024

View reviewed changes

scm/github/webhook.go Show resolved Hide resolved

scm/github/webhook.go Show resolved Hide resolved

timhuynh94 previously approved these changes Apr 8, 2024

View reviewed changes

plyr4 reviewed Apr 9, 2024

View reviewed changes

Merge branch 'main' into refactor/nested-api/repository

6d84769

github-actions bot reviewed Apr 9, 2024

View reviewed changes

plyr4 mentioned this pull request Apr 9, 2024

refactor: nested api objects, user go-vela/ui#790

Merged

plyr4 reviewed Apr 9, 2024

View reviewed changes

database/repo/get.go Show resolved Hide resolved

plyr4 reviewed Apr 9, 2024

View reviewed changes

database/repo/repo.go Show resolved Hide resolved

plyr4 reviewed Apr 9, 2024

View reviewed changes

api/types/repo.go Show resolved Hide resolved

wass3rw3rk requested changes Apr 9, 2024

View reviewed changes

address feedback

71f7d71

ecrupper dismissed timhuynh94’s stale review via 71f7d71 April 9, 2024 21:02

plyr4 previously approved these changes Apr 10, 2024

View reviewed changes

timhuynh94 previously approved these changes Apr 10, 2024

View reviewed changes

wass3rw3rk reviewed Apr 10, 2024

View reviewed changes

scm/service.go Outdated Show resolved Hide resolved

remove user param from functions that only use owner creds

74aa2c9

ecrupper dismissed stale reviews from timhuynh94 and plyr4 via 74aa2c9 April 10, 2024 15:27

plyr4 approved these changes Apr 10, 2024

View reviewed changes

wass3rw3rk approved these changes Apr 10, 2024

View reviewed changes

ecrupper merged commit 1058d96 into main Apr 10, 2024
13 of 16 checks passed

ecrupper deleted the refactor/nested-api/repository branch April 10, 2024 16:46

ecrupper mentioned this pull request Apr 18, 2024

refactor(build)!: move build from types and nest the object #1111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(repo)!: nested repository with migration from types #1095

refactor(repo)!: nested repository with migration from types #1095

ecrupper commented Mar 26, 2024

codecov bot commented Mar 26, 2024 •

edited

Loading

ecrupper commented Mar 26, 2024

github-actions bot Apr 5, 2024

timhuynh94 left a comment

plyr4 Apr 9, 2024

ecrupper Apr 9, 2024

plyr4 Apr 9, 2024

github-actions bot Apr 9, 2024

github-actions bot Apr 9, 2024

github-actions bot Apr 9, 2024

wass3rw3rk left a comment •

edited

Loading

		@@ -69,7 +69,7 @@ import (
		// expand and validate a pipeline configuration.
		func ValidatePipeline(c *gin.Context) {

refactor(repo)!: nested repository with migration from types #1095

refactor(repo)!: nested repository with migration from types #1095

Conversation

ecrupper commented Mar 26, 2024

codecov bot commented Mar 26, 2024 • edited Loading

Codecov Report

ecrupper commented Mar 26, 2024

github-actions bot Apr 5, 2024

Choose a reason for hiding this comment

timhuynh94 left a comment

Choose a reason for hiding this comment

plyr4 Apr 9, 2024

Choose a reason for hiding this comment

ecrupper Apr 9, 2024

Choose a reason for hiding this comment

plyr4 Apr 9, 2024

Choose a reason for hiding this comment

github-actions bot Apr 9, 2024

Choose a reason for hiding this comment

github-actions bot Apr 9, 2024

Choose a reason for hiding this comment

github-actions bot Apr 9, 2024

Choose a reason for hiding this comment

wass3rw3rk left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Mar 26, 2024 •

edited

Loading

wass3rw3rk left a comment •

edited

Loading