Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove deprecated linter rules #1123

Merged
merged 1 commit into from
May 8, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 8, 2024

structcheck, varcheck, and deadcode are all replaced by unused, which we already have enabled.

The newer versions of golangci-lint are now throwing errors when these are used.

@ecrupper ecrupper requested a review from a team as a code owner May 8, 2024 17:50
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (300ca45) to head (be3e831).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files         394      394           
  Lines       13284    13284           
=======================================
  Hits         9044     9044           
  Misses       3731     3731           
  Partials      509      509           

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@ecrupper ecrupper merged commit 76400eb into main May 8, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/ci/remove-deprecated-linter-rules branch May 8, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants