Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit hook retry loop on success #1179

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: exit hook retry loop on success #1179

merged 3 commits into from
Sep 11, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 11, 2024

fixes a regression introduced in #1175 where retryLimit - 1 duplicate hooks are created after success.

cc @jbrockopp

@plyr4 plyr4 requested a review from a team as a code owner September 11, 2024 14:17
ecrupper
ecrupper previously approved these changes Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.78%. Comparing base (6750763) to head (dcd5e3a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/webhook/post.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   52.79%   52.78%   -0.01%     
==========================================
  Files         551      551              
  Lines       19219    19220       +1     
==========================================
  Hits        10146    10146              
- Misses       8509     8510       +1     
  Partials      564      564              
Files with missing lines Coverage Δ
api/webhook/post.go 0.00% <0.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit d83c78e into main Sep 11, 2024
11 of 13 checks passed
@plyr4 plyr4 deleted the fix/webhook-retry branch September 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants