feat(auth): server side changes for new worker auth flow #790
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #790 +/- ##
=========================================
+ Coverage 0 56.48% +56.48%
=========================================
Files 0 243 +243
Lines 0 16164 +16164
=========================================
+ Hits 0 9131 +9131
- Misses 0 6628 +6628
- Partials 0 405 +405
|
api/worker.go
Outdated
| if secret, ok := c.Value("secret").(string); ok { | ||
| tkn := new(library.Token) | ||
| tkn.SetToken(secret) | ||
| c.JSON(http.StatusOK, WorkerCheckIn{Worker: w, Token: tkn}) |
There was a problem hiding this comment.
I think the swagger doc comment's 200 response needs to be updated to show the two different response types: Worker, and WorkerCheckIn.
There was a problem hiding this comment.
Also, sdk-go is going to need to know about both types that can be returned. Or, maybe the worker needs a different server end point it can use to check in and get the new token.
There was a problem hiding this comment.
The more I think about this, the more I think it should just be a separate endpoint altogether
There was a problem hiding this comment.
The latest commit decoupled UpdateWorker and RefreshWorkerAuth, which I think is much cleaner. Plus we don't have to create a temporary struct as a return type. I also took this change to its natural conclusion and eliminated platform admin access to refresh auth, as that can only cause problems in practice.
Thank you for the feedback!
Ref: go-vela/community#770
Dependent on: go-vela/types#283