Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/schedule): make validateEntry more strict and set updated_by using claims #901

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jul 7, 2023

Prior to this change, the entry 0 1,2,10,12 * * * with a VELA_SCHEDULE_MINIMUM_FREQUENCY of 180m would be considered valid if you added the schedule between the hours of 12:00 Zulu time and 1:00 Zulu time the next day. Won't catch all cases, but I figured it would catch more than enough.

Also set updated_by in the update schedule endpoint.

@ecrupper ecrupper self-assigned this Jul 7, 2023
@ecrupper ecrupper requested a review from a team as a code owner July 7, 2023 16:31
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #901 (165407e) into main (900608b) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

❗ Current head 165407e differs from pull request most recent head 6c5b7b4. Consider uploading reports for the commit 6c5b7b4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   71.48%   71.47%   -0.01%     
==========================================
  Files         304      304              
  Lines       12438    12450      +12     
==========================================
+ Hits         8891     8899       +8     
- Misses       3116     3120       +4     
  Partials      431      431              
Impacted Files Coverage Δ
api/schedule/update.go 0.00% <0.00%> (ø)
api/schedule/create.go 14.39% <66.66%> (+5.52%) ⬆️

JordanSussman
JordanSussman previously approved these changes Jul 7, 2023
@ecrupper ecrupper merged commit 71a484d into main Jul 7, 2023
11 checks passed
@ecrupper ecrupper deleted the fix-schedule-api-logic branch July 7, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants